Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from clone to built in structured clone #9068

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Aug 23, 2023

  • update jest
  • remove dependencies (no more commonjs deps)

@domoritz domoritz requested a review from lsh August 23, 2023 22:15
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not super keen on the use of any, but I can't think of a better way to achieve the same result.

@domoritz domoritz enabled auto-merge (squash) August 31, 2023 16:04
@domoritz domoritz merged commit 7874ea9 into main Aug 31, 2023
9 checks passed
@domoritz domoritz deleted the dom/structured-clone branch August 31, 2023 16:08
@kanitw
Copy link
Member

kanitw commented Sep 13, 2023

Why is this a feat?

@domoritz
Copy link
Member Author

It gets rid of a dependency and should enable esm support (which I haven't tested yet so I didn't highlight it here).

alliefeldman pushed a commit to alliefeldman/vega-lite that referenced this pull request Oct 2, 2023
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants